Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/safe_browsing/threat_details.cc

Issue 2623733002: Componentize SafeBrowsingBlockingPage for WebView use (Closed)
Patch Set: address final comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/threat_details.h ('k') | chrome/browser/safe_browsing/ui_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/threat_details.cc
diff --git a/chrome/browser/safe_browsing/threat_details.cc b/chrome/browser/safe_browsing/threat_details.cc
index 4f3d4b605dd369740e0c56eb94a193fc45d67694..5e5d6d74bb98e65ee9f5dde1d211cd3be29d8798 100644
--- a/chrome/browser/safe_browsing/threat_details.cc
+++ b/chrome/browser/safe_browsing/threat_details.cc
@@ -128,7 +128,7 @@ void ClearHttpsResource(ClientSafeBrowsingReportRequest::Resource* resource) {
class ThreatDetailsFactoryImpl : public ThreatDetailsFactory {
public:
ThreatDetails* CreateThreatDetails(
- SafeBrowsingUIManager* ui_manager,
+ BaseUIManager* ui_manager,
WebContents* web_contents,
const security_interstitials::UnsafeResource& unsafe_resource) override {
return new ThreatDetails(ui_manager, web_contents, unsafe_resource);
@@ -148,7 +148,7 @@ static base::LazyInstance<ThreatDetailsFactoryImpl>
// Create a ThreatDetails for the given tab.
/* static */
ThreatDetails* ThreatDetails::NewThreatDetails(
- SafeBrowsingUIManager* ui_manager,
+ BaseUIManager* ui_manager,
WebContents* web_contents,
const UnsafeResource& resource) {
// Set up the factory if this has not been done already (tests do that
@@ -159,7 +159,7 @@ ThreatDetails* ThreatDetails::NewThreatDetails(
}
// Create a ThreatDetails for the given tab. Runs in the UI thread.
-ThreatDetails::ThreatDetails(SafeBrowsingUIManager* ui_manager,
+ThreatDetails::ThreatDetails(BaseUIManager* ui_manager,
content::WebContents* web_contents,
const UnsafeResource& resource)
: content::WebContentsObserver(web_contents),
« no previous file with comments | « chrome/browser/safe_browsing/threat_details.h ('k') | chrome/browser/safe_browsing/ui_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698