Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2623713002: Followup to clang formatting (Closed)

Created:
3 years, 11 months ago by sczs
Modified:
3 years, 11 months ago
Reviewers:
sdefresne, lpromero
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Followup to clang formatting BUG=675359, 675358 Review-Url: https://codereview.chromium.org/2623713002 Cr-Commit-Position: refs/heads/master@{#442732} Committed: https://chromium.googlesource.com/chromium/src/+/8a4fdfe3c1fa302318dc3a68a332915e529f2e99

Patch Set 1 #

Total comments: 1

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M ios/chrome/app/chrome_exe_main.mm View 1 1 chunk +1 line, -4 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_navigation_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
sczs
PTAL
3 years, 11 months ago (2017-01-10 00:37:21 UTC) #3
sdefresne
https://codereview.chromium.org/2623713002/diff/1/ios/chrome/app/chrome_exe_main.mm File ios/chrome/app/chrome_exe_main.mm (right): https://codereview.chromium.org/2623713002/diff/1/ios/chrome/app/chrome_exe_main.mm#newcode37 ios/chrome/app/chrome_exe_main.mm:37: NSDictionary* pseudoDict = [NSDictionary Can you change this to ...
3 years, 11 months ago (2017-01-10 09:28:30 UTC) #4
sdefresne
lgtm
3 years, 11 months ago (2017-01-10 09:28:37 UTC) #5
lpromero
lgtm
3 years, 11 months ago (2017-01-10 10:19:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623713002/20001
3 years, 11 months ago (2017-01-10 23:39:04 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 23:45:01 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8a4fdfe3c1fa302318dc3a68a332...

Powered by Google App Engine
This is Rietveld 408576698