Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2624)

Unified Diff: Source/testing/runner/WebTestProxy.cpp

Issue 26237004: Remove unused editing related member functions from WebViewClient (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: 2013-10-09T17:59:14 Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/FocusController.cpp ('k') | Source/web/EditorClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/testing/runner/WebTestProxy.cpp
diff --git a/Source/testing/runner/WebTestProxy.cpp b/Source/testing/runner/WebTestProxy.cpp
index 64a2c24ef136196ebb5da0d4e8c4897d44e08a69..478218878779cc50159a93c8de06db91d6408e8f 100644
--- a/Source/testing/runner/WebTestProxy.cpp
+++ b/Source/testing/runner/WebTestProxy.cpp
@@ -944,87 +944,6 @@ void WebTestProxyBase::startDragging(WebFrame*, const WebDragData& data, WebDrag
// The output from these methods in layout test mode should match that
// expected by the layout tests. See EditingDelegate.m in DumpRenderTree.
-bool WebTestProxyBase::shouldBeginEditing(const WebRange& range)
-{
- if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks()) {
- m_delegate->printMessage("EDITING DELEGATE: shouldBeginEditingInDOMRange:");
- printRangeDescription(m_delegate, range);
- m_delegate->printMessage("\n");
- }
- return true;
-}
-
-bool WebTestProxyBase::shouldEndEditing(const WebRange& range)
-{
- if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks()) {
- m_delegate->printMessage("EDITING DELEGATE: shouldEndEditingInDOMRange:");
- printRangeDescription(m_delegate, range);
- m_delegate->printMessage("\n");
- }
- return true;
-}
-
-bool WebTestProxyBase::shouldInsertNode(const WebNode& node, const WebRange& range, WebEditingAction action)
-{
- if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks()) {
- m_delegate->printMessage("EDITING DELEGATE: shouldInsertNode:");
- printNodeDescription(m_delegate, node, 0);
- m_delegate->printMessage(" replacingDOMRange:");
- printRangeDescription(m_delegate, range);
- m_delegate->printMessage(string(" givenAction:") + editingActionDescription(action) + "\n");
- }
- return true;
-}
-
-bool WebTestProxyBase::shouldInsertText(const WebString& text, const WebRange& range, WebEditingAction action)
-{
- if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks()) {
- m_delegate->printMessage(string("EDITING DELEGATE: shouldInsertText:") + text.utf8().data() + " replacingDOMRange:");
- printRangeDescription(m_delegate, range);
- m_delegate->printMessage(string(" givenAction:") + editingActionDescription(action) + "\n");
- }
- return true;
-}
-
-bool WebTestProxyBase::shouldChangeSelectedRange(
- const WebRange& fromRange, const WebRange& toRange, WebTextAffinity affinity, bool stillSelecting)
-{
- if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks()) {
- m_delegate->printMessage("EDITING DELEGATE: shouldChangeSelectedDOMRange:");
- printRangeDescription(m_delegate, fromRange);
- m_delegate->printMessage(" toDOMRange:");
- printRangeDescription(m_delegate, toRange);
- m_delegate->printMessage(string(" affinity:") + textAffinityDescription(affinity) + " stillSelecting:" + (stillSelecting ? "TRUE" : "FALSE") + "\n");
- }
- return true;
-}
-
-bool WebTestProxyBase::shouldDeleteRange(const WebRange& range)
-{
- if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks()) {
- m_delegate->printMessage("EDITING DELEGATE: shouldDeleteDOMRange:");
- printRangeDescription(m_delegate, range);
- m_delegate->printMessage("\n");
- }
- return true;
-}
-
-bool WebTestProxyBase::shouldApplyStyle(const WebString& style, const WebRange& range)
-{
- if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks()) {
- m_delegate->printMessage(string("EDITING DELEGATE: shouldApplyStyle:") + style.utf8().data() + " toElementsInDOMRange:");
- printRangeDescription(m_delegate, range);
- m_delegate->printMessage("\n");
- }
- return true;
-}
-
-void WebTestProxyBase::didBeginEditing()
-{
- if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks())
- m_delegate->printMessage("EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification\n");
-}
-
void WebTestProxyBase::didChangeSelection(bool isEmptySelection)
{
if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks())
@@ -1037,12 +956,6 @@ void WebTestProxyBase::didChangeContents()
m_delegate->printMessage("EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification\n");
}
-void WebTestProxyBase::didEndEditing()
-{
- if (m_testInterfaces->testRunner()->shouldDumpEditingCallbacks())
- m_delegate->printMessage("EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification\n");
-}
-
bool WebTestProxyBase::createView(WebFrame*, const WebURLRequest& request, const WebWindowFeatures&, const WebString&, WebNavigationPolicy)
{
if (!m_testInterfaces->testRunner()->canOpenWindows())
« no previous file with comments | « Source/core/page/FocusController.cpp ('k') | Source/web/EditorClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698