Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: Source/core/page/FocusController.cpp

Issue 26237004: Remove unused editing related member functions from WebViewClient (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: 2013-10-09T17:59:14 Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/testing/runner/WebTestProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/FocusController.cpp
diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp
index 2c9ecd3aeed7e12124d351ecb403b6204e544ec7..341039a75d2d3885d7bd3ec75714bd2d2250f671 100644
--- a/Source/core/page/FocusController.cpp
+++ b/Source/core/page/FocusController.cpp
@@ -380,8 +380,7 @@ bool FocusController::advanceFocusInDocumentOrder(FocusDirection direction, bool
if (caretBrowsing) {
Position position = firstPositionInOrBeforeNode(element);
VisibleSelection newSelection(position, position, DOWNSTREAM);
- if (frame->selection().shouldChangeSelection(newSelection))
- frame->selection().setSelection(newSelection);
+ frame->selection().setSelection(newSelection);
}
element->focus(false, direction);
@@ -559,13 +558,7 @@ static bool relinquishesEditingFocus(Node *node)
{
ASSERT(node);
ASSERT(node->rendererIsEditable());
-
- Node* root = node->rootEditableElement();
- Frame* frame = node->document().frame();
- if (!frame || !root)
- return false;
-
- return frame->editor().shouldEndEditing(rangeOfContents(root).get());
+ return node->document().frame() && node->rootEditableElement();
}
static void clearSelectionIfNeeded(Frame* oldFocusedFrame, Frame* newFocusedFrame, Node* newFocusedNode)
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/testing/runner/WebTestProxy.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698