Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26237002: Removing сolon from cURL command header. (Closed)

Created:
7 years, 2 months ago by SeRya
Modified:
7 years, 2 months ago
Reviewers:
aandrey, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Removing сolon from cURL command header. BUG=301787 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160186

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M LayoutTests/inspector/curl-command.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/curl-command-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/linux/inspector/curl-command-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/inspector/curl-command-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/NetworkPanel.js View 1 2 3 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
SeRya
7 years, 2 months ago (2013-10-07 12:18:16 UTC) #1
aandrey
https://codereview.chromium.org/26237002/diff/4001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/26237002/diff/4001/Source/devtools/front_end/NetworkPanel.js#newcode1384 Source/devtools/front_end/NetworkPanel.js:1384: var ignoredHeaders = {"host": 1, "method": 1, "path": 1, ...
7 years, 2 months ago (2013-10-11 09:11:11 UTC) #2
SeRya
https://codereview.chromium.org/26237002/diff/4001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/26237002/diff/4001/Source/devtools/front_end/NetworkPanel.js#newcode1384 Source/devtools/front_end/NetworkPanel.js:1384: var ignoredHeaders = {"host": 1, "method": 1, "path": 1, ...
7 years, 2 months ago (2013-10-21 12:22:46 UTC) #3
aandrey
https://codereview.chromium.org/26237002/diff/12001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/26237002/diff/12001/Source/devtools/front_end/NetworkPanel.js#newcode1375 Source/devtools/front_end/NetworkPanel.js:1375: var ignoredHeaders = {"host": 1, "method": 1, "path": 1, ...
7 years, 2 months ago (2013-10-21 12:35:54 UTC) #4
SeRya
https://codereview.chromium.org/26237002/diff/12001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/26237002/diff/12001/Source/devtools/front_end/NetworkPanel.js#newcode1375 Source/devtools/front_end/NetworkPanel.js:1375: var ignoredHeaders = {"host": 1, "method": 1, "path": 1, ...
7 years, 2 months ago (2013-10-21 13:05:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/26237002/92001
7 years, 2 months ago (2013-10-21 14:41:48 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12730
7 years, 2 months ago (2013-10-21 18:43:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/26237002/92001
7 years, 2 months ago (2013-10-22 07:59:59 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 11:21:19 UTC) #9
Message was sent while issue was closed. 
Change committed as 160186

Powered by Google App Engine
This is Rietveld 408576698