Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: Source/devtools/front_end/NetworkPanel.js

Issue 26237002: Removing сolon from cURL command header. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/win/inspector/curl-command-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/NetworkPanel.js
diff --git a/Source/devtools/front_end/NetworkPanel.js b/Source/devtools/front_end/NetworkPanel.js
index 1c07671f38d78362d8e9e7e44f162e03456ac295..2635ae56bdc63dcd6baf809ccb56d20917597812 100644
--- a/Source/devtools/front_end/NetworkPanel.js
+++ b/Source/devtools/front_end/NetworkPanel.js
@@ -1372,7 +1372,8 @@ WebInspector.NetworkLogView.prototype = {
_generateCurlCommand: function(request)
{
var command = ["curl"];
- var ignoredHeaders = {};
+ // These headers are derived from URL (except "version") and would be added by cURL anyway.
+ var ignoredHeaders = {"host": 1, "method": 1, "path": 1, "scheme": 1, "version": 1};
function escapeStringWin(str)
{
@@ -1434,12 +1435,12 @@ WebInspector.NetworkLogView.prototype = {
if (requestContentType && requestContentType.startsWith("application/x-www-form-urlencoded") && request.requestFormData) {
data.push("--data");
data.push(escapeString(request.requestFormData));
- ignoredHeaders["Content-Length"] = true;
+ ignoredHeaders["content-length"] = true;
inferredMethod = "POST";
} else if (request.requestFormData) {
data.push("--data-binary");
data.push(escapeString(request.requestFormData));
- ignoredHeaders["Content-Length"] = true;
+ ignoredHeaders["content-length"] = true;
inferredMethod = "POST";
}
@@ -1450,10 +1451,11 @@ WebInspector.NetworkLogView.prototype = {
for (var i = 0; i < request.requestHeaders.length; i++) {
var header = request.requestHeaders[i];
- if (header.name in ignoredHeaders)
+ var name = header.name.replace(/^:/, ""); // Translate SPDY v3 headers to HTTP headers.
+ if (name.toLowerCase() in ignoredHeaders)
continue;
command.push("-H");
- command.push(escapeString(header.name + ": " + header.value));
+ command.push(escapeString(name + ": " + header.value));
}
command = command.concat(data);
command.push("--compressed");
« no previous file with comments | « LayoutTests/platform/win/inspector/curl-command-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698