Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2623693003: Move more vector icons into respective directories. (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, tfarina, oshima+watch_chromium.org, mac-reviews_chromium.org, kalyank, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more vector icons into respective directories. BUG=626786 Review-Url: https://codereview.chromium.org/2623693003 Cr-Commit-Position: refs/heads/master@{#442481} Committed: https://chromium.googlesource.com/chromium/src/+/1b92771b6d4a397129523f92eb829b295109c808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -806 lines) Patch
M ash/common/shelf/overflow_button.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/session/logout_button_tray.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/common/system/overview/overview_button_tray.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/resources/vector_icons/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
A + ash/resources/vector_icons/shelf_keyboard.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/resources/vector_icons/shelf_keyboard.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/resources/vector_icons/shelf_logout.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/resources/vector_icons/shelf_logout.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/resources/vector_icons/shelf_overflow.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/resources/vector_icons/shelf_overflow.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/resources/vector_icons/shelf_overview.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/resources/vector_icons/shelf_overview.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/vector_icons/BUILD.gn View 2 chunks +17 lines, -0 lines 0 comments Download
A + chrome/app/vector_icons/laptop.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/smartphone.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_audio.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_audio.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_audio_muting.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_audio_muting.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_bluetooth_connected.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_close_hovered_pressed.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_close_hovered_pressed.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_close_normal.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_close_normal.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_media_capturing.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_media_recording.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_usb_connected.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tab_usb_connected.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/tablet.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/cocoa/hover_close_button.mm View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 3 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M ui/gfx/vector_icons/BUILD.gn View 2 chunks +0 lines, -25 lines 0 comments Download
D ui/gfx/vector_icons/laptop.icon View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/gfx/vector_icons/shelf_keyboard.icon View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/gfx/vector_icons/shelf_keyboard.1x.icon View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/gfx/vector_icons/shelf_logout.icon View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/gfx/vector_icons/shelf_logout.1x.icon View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/gfx/vector_icons/shelf_overflow.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/shelf_overflow.1x.icon View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/gfx/vector_icons/shelf_overview.icon View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/gfx/vector_icons/shelf_overview.1x.icon View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/gfx/vector_icons/smartphone.icon View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/gfx/vector_icons/tab.icon View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/gfx/vector_icons/tab_audio.icon View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/gfx/vector_icons/tab_audio.1x.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/tab_audio_muting.icon View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/gfx/vector_icons/tab_audio_muting.1x.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gfx/vector_icons/tab_bluetooth_connected.icon View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/gfx/vector_icons/tab_close_hovered_pressed.icon View 1 chunk +0 lines, -15 lines 0 comments Download
D ui/gfx/vector_icons/tab_close_hovered_pressed.1x.icon View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/gfx/vector_icons/tab_close_normal.icon View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/gfx/vector_icons/tab_close_normal.1x.icon View 1 chunk +0 lines, -13 lines 0 comments Download
D ui/gfx/vector_icons/tab_media_capturing.icon View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/gfx/vector_icons/tab_media_recording.icon View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/gfx/vector_icons/tab_usb_connected.icon View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/gfx/vector_icons/tab_usb_connected.1x.icon View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/gfx/vector_icons/tablet.icon View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Evan Stade
mostly mechanical changes
3 years, 11 months ago (2017-01-10 00:58:19 UTC) #4
sky
LGTM (mostly rubber stamp)
3 years, 11 months ago (2017-01-10 03:29:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623693003/1
3 years, 11 months ago (2017-01-10 04:06:59 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 04:51:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b92771b6d4a397129523f92eb82...

Powered by Google App Engine
This is Rietveld 408576698