Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2623683002: [intl] Remove redundant type checking system (Closed)

Created:
3 years, 11 months ago by Dan Ehrenberg
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intl] Remove redundant type checking system Previously, the Intl implementation tracked types two ways: - In the intl_initialized_marker_symbol - In various named properties of the intl_impl_object_symbol value As far as I can tell, these will never disagree with each other, modulo bugs in Intl itself. This patch removes the second type checking system. This reland includes a fixed type check for Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl method which is not bound. All future methods will follow this pattern. The second reland ensures that a newly inserted test is only run if Intl is present. BUG=v8:5751, chromium:677055, v8:4962 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng TBR=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2623683002 Cr-Commit-Position: refs/heads/master@{#42152} Committed: https://chromium.googlesource.com/v8/v8/+/788c96a95525f70f81e7b2786dff9f2f09ecad1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -65 lines) Patch
M src/i18n.cc View 4 chunks +4 lines, -36 lines 0 comments Download
M src/js/i18n.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 13 chunks +9 lines, -29 lines 0 comments Download
A test/intl/bad-target.js View 1 chunk +39 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4962.js View 1 chunk +11 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-677055.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623683002/1
3 years, 11 months ago (2017-01-09 21:59:45 UTC) #2
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 22:25:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/788c96a95525f70f81e7b2786dff9f2f09e...

Powered by Google App Engine
This is Rietveld 408576698