Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2623653003: [Payments] Move Payment Request test files to chrome/test/data/payments (Closed)

Created:
3 years, 11 months ago by Mathieu
Modified:
3 years, 11 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Move Payment Request test files to chrome/test/data/payments Will allow files to be used for desktop testing. BUG=679734 TEST=existing TBR=dfalcantara Review-Url: https://codereview.chromium.org/2623653003 Cr-Commit-Position: refs/heads/master@{#442593} Committed: https://chromium.googlesource.com/chromium/src/+/432cb34b6e2b52305b2ce64373117185513c707a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-46 lines, -1844 lines) Patch
M WATCHLISTS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/payments/payment_request_web_contents_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/payments/site_per_process_payments_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/android/payments/abort.js View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/test/data/android/payments/basic_card.js View 1 chunk +0 lines, -274 lines 0 comments Download
D chrome/test/data/android/payments/bobpay.js View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/test/data/android/payments/bobpay_and_cards.js View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/test/data/android/payments/can_make_payment_query.js View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/test/data/android/payments/can_make_payment_query_bobpay.js View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/test/data/android/payments/can_make_payment_query_cc.js View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/test/data/android/payments/contact_details.js View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/test/data/android/payments/contact_details_and_free_shipping.js View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/test/data/android/payments/dynamic_shipping.js View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/test/data/android/payments/email.js View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/test/data/android/payments/email_and_free_shipping.js View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/test/data/android/payments/email_and_phone.js View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/test/data/android/payments/extra_shipping_options.js View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/test/data/android/payments/fail_complete.js View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/data/android/payments/free_shipping.js View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/test/data/android/payments/metrics.js View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/test/data/android/payments/name.js View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/test/data/android/payments/name_and_free_shipping.js View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/test/data/android/payments/no_shipping.js View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_abort_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_basic_card_test.html View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_bobpay_and_cards_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_bobpay_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_can_make_payment_query_bobpay_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_can_make_payment_query_cc_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_can_make_payment_query_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_contact_details_and_free_shipping_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_contact_details_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_dynamic_shipping_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_email_and_free_shipping_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_email_and_phone_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_email_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_extra_shipping_options_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_fail_complete_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_free_shipping_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_metrics_test.html View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_name_and_free_shipping_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_name_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_no_shipping_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_phone_and_free_shipping_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_phone_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_show_twice_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/phone.js View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/test/data/android/payments/phone_and_free_shipping.js View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/test/data/android/payments/show_twice.js View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/test/data/android/payments/style.css View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/test/data/android/payments/util.js View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/test/data/payment_request_iframe.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/payment_request_main.html View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/payment_request_multiple_requests.html View 1 chunk +0 lines, -9 lines 0 comments Download
A + chrome/test/data/payments/abort.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/basic_card.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/bobpay.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/bobpay_and_cards.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/can_make_payment_query.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/can_make_payment_query_bobpay.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/can_make_payment_query_cc.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/contact_details.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/contact_details_and_free_shipping.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/dynamic_shipping.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/email.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/email_and_free_shipping.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/email_and_phone.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/extra_shipping_options.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/fail_complete.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/free_shipping.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/metrics.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/name.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/name_and_free_shipping.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/no_shipping.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_abort_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_basic_card_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_bobpay_and_cards_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_bobpay_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_can_make_payment_query_bobpay_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_can_make_payment_query_cc_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_can_make_payment_query_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_contact_details_and_free_shipping_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_contact_details_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_dynamic_shipping_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_email_and_free_shipping_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_email_and_phone_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_email_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_extra_shipping_options_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_fail_complete_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_free_shipping_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_metrics_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_multiple_requests.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_name_and_free_shipping_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_name_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_no_shipping_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_phone_and_free_shipping_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_phone_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/payment_request_show_twice_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/phone.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/phone_and_free_shipping.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/show_twice.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/style.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/payments/util.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Mathieu
Hi, PTAL. I've sent a CQ dry run.
3 years, 11 months ago (2017-01-10 14:32:44 UTC) #5
please use gerrit instead
lgtm
3 years, 11 months ago (2017-01-10 14:34:00 UTC) #7
Mathieu
TBR dfalcantara for the small chrome/android/BUILD.gn change.
3 years, 11 months ago (2017-01-10 14:36:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623653003/1
3 years, 11 months ago (2017-01-10 14:37:13 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/432cb34b6e2b52305b2ce64373117185513c707a
3 years, 11 months ago (2017-01-10 15:45:33 UTC) #16
gone
3 years, 11 months ago (2017-01-10 18:15:27 UTC) #17
Message was sent while issue was closed.
Answering the TBR signal:
lgtm

Powered by Google App Engine
This is Rietveld 408576698