Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 2623643002: Add TOS-accepted Java pref on Android. (Closed)

Created:
3 years, 11 months ago by Alexei Svitkine (slow)
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Add TOS-accepted Java pref on Android. This will support being able to show the first page of the FRE without native code being initialized yet, so that we could fetch a variations seed while it's showing, which I'm working on under crbug.com/632199 This change adds a Java-level pref for TOS-accepted, so it can be checked before native is initialized. Also makes the code sync the existing native pref to the Java pref for users migrating from old versions. (We may want to merge this CL back ahead of the main FRE de-nativization work so that users can migrate their prefs ahead of time.) BUG=668741 Review-Url: https://codereview.chromium.org/2531743003 Cr-Commit-Position: refs/heads/master@{#435283} (cherry picked from commit 03e06cc174fe2cbba5fab1291442e470e5e94b09) Review-Url: https://codereview.chromium.org/2623643002 . Cr-Commit-Position: refs/branch-heads/2924@{#705} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/e4fc556210b701b9da0c446212f753c707723655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java View 2 chunks +25 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexei Svitkine (slow)
3 years, 11 months ago (2017-01-09 20:23:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4fc556210b701b9da0c446212f753c707723655.

Powered by Google App Engine
This is Rietveld 408576698