Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Issue 2623613007: [Payments] Disable flaky test only on KitKat. (Closed)

Created:
3 years, 11 months ago by sebsg
Modified:
3 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Disable flaky test only on KitKat. BUG=678983 Review-Url: https://codereview.chromium.org/2623613007 Cr-Commit-Position: refs/heads/master@{#442700} Committed: https://chromium.googlesource.com/chromium/src/+/9ff3d6e6ca6268c5c0789de863600edb20485bd6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Put the right version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sebsg
Hi Dan, PTAL Thanks!
3 years, 11 months ago (2017-01-10 15:27:06 UTC) #3
sebsg
Hi Dan, PTAL Thanks!
3 years, 11 months ago (2017-01-10 15:27:07 UTC) #4
gone
https://codereview.chromium.org/2623613007/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java (right): https://codereview.chromium.org/2623613007/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java#newcode118 chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java:118: @MinAndroidSdkLevel(Build.VERSION_CODES.KITKAT) // crbug.com/678983 This makes the test run on ...
3 years, 11 months ago (2017-01-10 19:48:33 UTC) #5
sebsg
Fixed it, thanks! https://codereview.chromium.org/2623613007/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java (right): https://codereview.chromium.org/2623613007/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java#newcode118 chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java:118: @MinAndroidSdkLevel(Build.VERSION_CODES.KITKAT) // crbug.com/678983 On 2017/01/10 19:48:33, ...
3 years, 11 months ago (2017-01-10 21:31:39 UTC) #6
gone
lgtm
3 years, 11 months ago (2017-01-10 21:32:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623613007/40001
3 years, 11 months ago (2017-01-10 21:32:54 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 21:52:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9ff3d6e6ca6268c5c0789de86360...

Powered by Google App Engine
This is Rietveld 408576698