Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2623613004: SharedWorker: Move classes under content/renderer to content/renderer/shared_worker (Closed)

Created:
3 years, 11 months ago by nhiroki
Modified:
3 years, 11 months ago
Reviewers:
kinuko, horo
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SharedWorker: Move classes under content/renderer to content/renderer/shared_worker There would be no reason to place SharedWorkerRepository and WebSharedWorkerProxy under content/renderer. This CL moves them into content/renderer/shared_worker. BUG=612308 Review-Url: https://codereview.chromium.org/2623613004 Cr-Commit-Position: refs/heads/master@{#442532} Committed: https://chromium.googlesource.com/chromium/src/+/2820b8b5aedcac72f5abe607d52310ec5061ea1b

Patch Set 1 #

Patch Set 2 : fix include guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -295 lines) Patch
M content/renderer/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/shared_worker/shared_worker_repository.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/shared_worker/shared_worker_repository.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/renderer/shared_worker/websharedworker_proxy.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/shared_worker/websharedworker_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/renderer/shared_worker_repository.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/renderer/shared_worker_repository.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D content/renderer/websharedworker_proxy.h View 1 chunk +0 lines, -72 lines 0 comments Download
D content/renderer/websharedworker_proxy.cc View 1 chunk +0 lines, -104 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
nhiroki
PTAL, thanks.
3 years, 11 months ago (2017-01-10 03:50:24 UTC) #5
kinuko
lgtm
3 years, 11 months ago (2017-01-10 05:21:59 UTC) #6
horo
lgtm
3 years, 11 months ago (2017-01-10 07:11:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623613004/20001
3 years, 11 months ago (2017-01-10 08:09:54 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 08:14:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2820b8b5aedcac72f5abe607d523...

Powered by Google App Engine
This is Rietveld 408576698