Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issue 2623613002: Reland 2617183002 without offending tests (Closed)

Created:
3 years, 11 months ago by bsheedy
Modified:
3 years, 11 months ago
Reviewers:
bajones
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, haraken, feature-vr-reviews_chromium.org, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland 2617183002 without offending tests 2617183002 was reverted in https://bugs.chromium.org/p/chromium/issues/detail?id=679288 due to a couple of leaking tests. This is being investigated in https://bugs.chromium.org/p/chromium/issues/detail?id=679401, but in the meantime, we can re-land the other tests that weren't causing issues. BUG=675325, 670490, 650703 Review-Url: https://codereview.chromium.org/2623613002 Cr-Commit-Position: refs/heads/master@{#442447} Committed: https://chromium.googlesource.com/chromium/src/+/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+815 lines, -282 lines) Patch
A third_party/WebKit/LayoutTests/vr/exitPresent_reject_notpresenting.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/exitPresent_resolve.html View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/getLayers_notpresenting.html View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/getLayers_presenting.html View 1 chunk +58 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html View 1 chunk +20 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html View 1 chunk +39 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/getVRDisplays_zero_display.html View 1 chunk +14 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/requestAnimationFrame_called.html View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_badleftbounds.html View 1 chunk +27 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_badrightbounds.html View 1 chunk +27 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_nogesture.html View 1 chunk +16 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_nolayers.html View 1 chunk +23 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_nosource.html View 1 chunk +23 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_notsupported.html View 1 chunk +23 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_nowebgl.html View 1 chunk +25 lines, -22 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/requestPresent_reject_nullsource.html View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_toomanylayers.html View 1 chunk +28 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html View 1 chunk +23 lines, -20 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html View 1 chunk +56 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html View 1 chunk +37 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_resolve_webgl2.html View 1 chunk +26 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js View 2 chunks +39 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js View 1 chunk +4 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/resources/test-constants.js View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/stageParameters_match.html View 1 chunk +47 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsheedy
3 years, 11 months ago (2017-01-09 19:53:39 UTC) #2
bajones
LGTM
3 years, 11 months ago (2017-01-09 23:34:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623613002/1
3 years, 11 months ago (2017-01-09 23:36:20 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 02:05:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20e4bfed4baf6f6eac0d7142bb9e...

Powered by Google App Engine
This is Rietveld 408576698