Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2623583005: Remove call to stopLoading when loading Distilled version. (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
gambard
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove call to stopLoading when loading Distilled version. Stop loading destroys the pending entry which leads to a crash in release. Remove the call to stop. BUG=679721 Review-Url: https://codereview.chromium.org/2623583005 Cr-Commit-Position: refs/heads/master@{#442856} Committed: https://chromium.googlesource.com/chromium/src/+/e5a88e66c2120ec14fe98ec23da580300064dbbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ios/chrome/browser/reading_list/reading_list_web_state_observer.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Olivier
3 years, 11 months ago (2017-01-10 18:06:10 UTC) #2
gambard
lgtm
3 years, 11 months ago (2017-01-11 08:04:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623583005/1
3 years, 11 months ago (2017-01-11 08:10:18 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:30:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5a88e66c2120ec14fe98ec23da5...

Powered by Google App Engine
This is Rietveld 408576698