Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2623583004: PreParser scope analysis: simplify DeclareAndInitializeVariables. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PreParser scope analysis: simplify DeclareAndInitializeVariables. Now we have declarations too, so it doesn't matter whether preparser produces the same unresolved variables as the parser. BUG=v8:5501, v8:5516 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2623583004 Cr-Commit-Position: refs/heads/master@{#42174} Committed: https://chromium.googlesource.com/v8/v8/+/8f1353256f5cd814e490194a52862ff0bad4e83e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M src/parsing/preparser.cc View 1 chunk +1 line, -15 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
marja
ptal
3 years, 11 months ago (2017-01-10 11:33:49 UTC) #3
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-10 12:16:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623583004/1
3 years, 11 months ago (2017-01-10 12:31:27 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 12:33:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8f1353256f5cd814e490194a52862ff0bad...

Powered by Google App Engine
This is Rietveld 408576698