objects.h splitting: move ModuleInfo

objects.h splitting: move ModuleInfo

Including a fix: object-macros.h needs to be the last include: otherwise
we'll have a problem when a file does this:

#include "object-macros.h"
#include "x.h" // x.h also includes object-macros.h

BUG=v8:5402
Review-Url: https://codereview.chromium.org/2623573003
Cr-Commit-Position: refs/heads/master@{#42187}
Committed: https://chromium.googlesource.com/v8/v8/+/03762b8488de0e393077e3f40fe7b63e675b3af3

[marja, 2017-01-10 13:36:22]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 13:36:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 14:04:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 14:04:46]

Dry run: This issue passed the CQ dry run.

[marja, 2017-01-10 14:23:31]

Description was changed from

==========
objects.h splitting: move ModuleInfo

BUG=v8:5402
==========

to

==========
objects.h splitting: move ModuleInfo

Including a fix: object-macros.h needs to be the last include: otherwise
we'll have a problem when a file does this:

#include "object-macros.h"
#include "x.h" // x.h also includes object-macros.h

BUG=v8:5402
==========

[marja, 2017-01-10 14:23:31]

marja@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[marja, 2017-01-10 14:27:00]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 14:27:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-01-10 14:31:36]

ptal

[Michael Starzinger, 2017-01-10 15:26:24]

LGTM.

https://codereview.chromium.org/2623573003/diff/60001/src/objects/scope-info.h
File src/objects/scope-info.h (right):

https://codereview.chromium.org/2623573003/diff/60001/src/objects/scope-info....
src/objects/scope-info.h:13: // Has to be the last include:
nit: Maybe add "[...] because is doesn't have include guards" to the comment,
here and in the other places. WDYT?

[marja, 2017-01-10 15:36:36]

https://codereview.chromium.org/2623573003/diff/60001/src/objects/scope-info.h
File src/objects/scope-info.h (right):

https://codereview.chromium.org/2623573003/diff/60001/src/objects/scope-info....
src/objects/scope-info.h:13: // Has to be the last include:
On 2017/01/10 15:26:24, Michael Starzinger wrote:
> nit: Maybe add "[...] because is doesn't have include guards" to the comment,
> here and in the other places. WDYT?

Need to think of how to best explain this in 1 line; for now changed this
comment to be: Has to be the last include (doesn't have include guards):

[marja, 2017-01-10 15:36:40]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-10 15:36:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2623573003/#ps80002
(title: "ditto")

[commit-bot: I haz the power, 2017-01-10 15:36:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 16:05:35]

CQ is committing da patch.

Bot data: {"patchset_id": 80002, "attempt_start_ts": 1484062600519050,
"parent_rev": "bf67ce5f55c8784e3d39d0c823f31dc5c723c63e", "commit_rev":
"03762b8488de0e393077e3f40fe7b63e675b3af3"}

[commit-bot: I haz the power, 2017-01-10 16:05:39]

Description was changed from

==========
objects.h splitting: move ModuleInfo

Including a fix: object-macros.h needs to be the last include: otherwise
we'll have a problem when a file does this:

#include "object-macros.h"
#include "x.h" // x.h also includes object-macros.h

BUG=v8:5402
==========

to

==========
objects.h splitting: move ModuleInfo

Including a fix: object-macros.h needs to be the last include: otherwise
we'll have a problem when a file does this:

#include "object-macros.h"
#include "x.h" // x.h also includes object-macros.h

BUG=v8:5402

Review-Url: https://codereview.chromium.org/2623573003
Cr-Commit-Position: refs/heads/master@{#42187}
Committed:
https://chromium.googlesource.com/v8/v8/+/03762b8488de0e393077e3f40fe7b63e675...
==========

[commit-bot: I haz the power, 2017-01-10 16:05:40]

Committed patchset #6 (id:80002) as
https://chromium.googlesource.com/v8/v8/+/03762b8488de0e393077e3f40fe7b63e675...