Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2623573002: [MD Settings] Remove dead password hiding logic. (Closed)

Created:
3 years, 11 months ago by hcarmona
Modified:
3 years, 11 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings] Remove dead password hiding logic. BUG=595575 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2623573002 Cr-Commit-Position: refs/heads/master@{#442385} Committed: https://chromium.googlesource.com/chromium/src/+/625e34af3f15b18fced1c4d4affdc1b6a579ba44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
hcarmona
PTAL
3 years, 11 months ago (2017-01-09 18:38:04 UTC) #5
dschuyler
lgtm
3 years, 11 months ago (2017-01-09 22:04:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623573002/1
3 years, 11 months ago (2017-01-09 22:26:31 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 22:48:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/625e34af3f15b18fced1c4d4affd...

Powered by Google App Engine
This is Rietveld 408576698