Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2623553003: precache: Add geometric resource weight function. (Closed)

Created:
3 years, 11 months ago by twifkak
Modified:
3 years, 11 months ago
Reviewers:
bengr
CC:
chromium-reviews, wifiprefetch-reviews_google.com, jamartin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

precache: Add geometric resource weight function. Add an alternative function for combining resource weight with host visit frequency. This one is a measure of the probability that there will be a cache hit for the resource, given that resource_weight is the probability of a cache hit for a single trial and host_visits is the number of independent trials. BUG= Review-Url: https://codereview.chromium.org/2623553003 Cr-Commit-Position: refs/heads/master@{#443464} Committed: https://chromium.googlesource.com/chromium/src/+/591b347c5ffa6c9841a0ae9e08e28b3820ed9641

Patch Set 1 #

Patch Set 2 : Add comments and tests. #

Total comments: 2

Patch Set 3 : Add function comments. #

Patch Set 4 : Rebase. #

Patch Set 5 : Add default case, needed by some compilers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -7 lines) Patch
M components/precache/core/precache_fetcher.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 1 2 3 4 3 chunks +36 lines, -4 lines 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 1 2 3 4 chunks +35 lines, -3 lines 0 comments Download
M components/precache/core/proto/precache.proto View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
twifkak
3 years, 11 months ago (2017-01-10 02:12:47 UTC) #2
twifkak
bengr: PTAL. jamartin reviewed over IM but due to login issues was unable to leave ...
3 years, 11 months ago (2017-01-11 22:25:09 UTC) #4
bengr
lgtm modulo requests for comments. https://codereview.chromium.org/2623553003/diff/20001/components/precache/core/precache_fetcher.cc File components/precache/core/precache_fetcher.cc (right): https://codereview.chromium.org/2623553003/diff/20001/components/precache/core/precache_fetcher.cc#newcode231 components/precache/core/precache_fetcher.cc:231: // Models the expected ...
3 years, 11 months ago (2017-01-12 18:48:02 UTC) #5
twifkak
Thanks! Submitting. https://codereview.chromium.org/2623553003/diff/20001/components/precache/core/precache_fetcher.cc File components/precache/core/precache_fetcher.cc (right): https://codereview.chromium.org/2623553003/diff/20001/components/precache/core/precache_fetcher.cc#newcode231 components/precache/core/precache_fetcher.cc:231: // Models the expected number of requests ...
3 years, 11 months ago (2017-01-12 20:53:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623553003/40001
3 years, 11 months ago (2017-01-12 20:54:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/135000) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-12 20:57:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623553003/60001
3 years, 11 months ago (2017-01-12 21:00:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/99468)
3 years, 11 months ago (2017-01-12 21:29:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623553003/80001
3 years, 11 months ago (2017-01-12 23:12:57 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 02:14:39 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/591b347c5ffa6c9841a0ae9e08e2...

Powered by Google App Engine
This is Rietveld 408576698