[wrapper-tracing] Fix tracing of WebGL2RenderingContextBase

[wrapper-tracing] Fix tracing of WebGL2RenderingContextBase

We are not allowed to short-circuit tracing here (and actually nowhere) because
the rendering context can regain a context and at this point tracing is off,
i.e., the object is already black but members have not been traced.

We don't want black to white transitions in wrapper tracing, so just trace the
body of WebGL2RenderingContextBase unconditionally. The overhead should be
negligible.

BUG=chromium:678016
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623513003
Cr-Commit-Position: refs/heads/master@{#442379}
Committed: https://chromium.googlesource.com/chromium/src/+/55871d7b7bf86a7e67cd5380d6fb2e1ffdc44f98

[Michael Lippautz, 2017-01-09 13:54:01]

Description was changed from

==========
[wrapper-tracing] Fix tracing of WebGL2RenderingContextBase

We are not allowed to short-circuit tracing here (and actually nowhere) because
the rendering context can regain a context and at this point tracing is off,
i.e., the object is already black but members have not been traced.

We don't want black to white transitions in wrapper tracing, so just trace the
body of WebGL2RenderingContextBase unconditionally. The overhead should be
negligible.

BUG=chromium:678016
==========

to

==========
[wrapper-tracing] Fix tracing of WebGL2RenderingContextBase

We are not allowed to short-circuit tracing here (and actually nowhere) because
the rendering context can regain a context and at this point tracing is off,
i.e., the object is already black but members have not been traced.

We don't want black to white transitions in wrapper tracing, so just trace the
body of WebGL2RenderingContextBase unconditionally. The overhead should be
negligible.

BUG=chromium:678016
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-01-09 13:55:33]

mlippautz@chromium.org changed reviewers:
+ haraken@chromium.org, kbr@chromium.org

[Michael Lippautz, 2017-01-09 13:55:34]

ptal

kbr: If WebGL2RenderinContextBase can be reassigned a context,i.e., the object
is reused, then this fixes the bug in question. (See bug description)

[Michael Lippautz, 2017-01-09 13:55:39]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 13:55:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-01-09 13:57:01]

I think your analysis is correct. LGTM on my side.

[commit-bot: I haz the power, 2017-01-09 15:31:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 15:31:06]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-01-09 22:04:28]

LGTM

Yes, this is exactly what this test does. Sorry for the confusion in this area.
Thanks for taking care of this. Let me CQ this for you now.

[Ken Russell (switch to Gerrit), 2017-01-09 22:04:31]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:05:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2017-01-09 22:19:08]

On 2017/01/09 22:04:28, Ken Russell wrote:
> LGTM
> 
> Yes, this is exactly what this test does. Sorry for the confusion in this
area.
> Thanks for taking care of this. Let me CQ this for you now.

Thanks for the patience and helping me think through this!

[commit-bot: I haz the power, 2017-01-09 22:40:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483999471709300, "parent_rev":
"a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9", "commit_rev":
"55871d7b7bf86a7e67cd5380d6fb2e1ffdc44f98"}

[commit-bot: I haz the power, 2017-01-09 22:40:37]

Description was changed from

==========
[wrapper-tracing] Fix tracing of WebGL2RenderingContextBase

We are not allowed to short-circuit tracing here (and actually nowhere) because
the rendering context can regain a context and at this point tracing is off,
i.e., the object is already black but members have not been traced.

We don't want black to white transitions in wrapper tracing, so just trace the
body of WebGL2RenderingContextBase unconditionally. The overhead should be
negligible.

BUG=chromium:678016
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[wrapper-tracing] Fix tracing of WebGL2RenderingContextBase

We are not allowed to short-circuit tracing here (and actually nowhere) because
the rendering context can regain a context and at this point tracing is off,
i.e., the object is already black but members have not been traced.

We don't want black to white transitions in wrapper tracing, so just trace the
body of WebGL2RenderingContextBase unconditionally. The overhead should be
negligible.

BUG=chromium:678016
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623513003
Cr-Commit-Position: refs/heads/master@{#442379}
Committed:
https://chromium.googlesource.com/chromium/src/+/55871d7b7bf86a7e67cd5380d6fb...
==========

[commit-bot: I haz the power, 2017-01-09 22:40:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55871d7b7bf86a7e67cd5380d6fb...