[cleanup] Port KeyedLoadIC_{Slow,Miss} to TF and drop unused IC handler code

[cleanup] Port KeyedLoadIC_{Slow,Miss} to TF and drop unused IC handler code

BUG=v8:5269
Review-Url: https://codereview.chromium.org/2623483002
Cr-Commit-Position: refs/heads/master@{#42171}
Committed: https://chromium.googlesource.com/v8/v8/+/099abc58a16d9d92c4939dddc96ef98a4f60e870

[Jakob Kummerow, 2017-01-09 11:56:53]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2017-01-09 11:56:54]

PTAL.

[Igor Sheludko, 2017-01-09 12:05:18]

lgtm with a nit:

https://codereview.chromium.org/2623483002/diff/1/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2623483002/diff/1/src/builtins/builtins.h#new...
src/builtins/builtins.h:216: TFS(KeyedLoadIC_Slow, HANDLER, Code::KEYED_LOAD_IC,
Load)                    \
It's a handler therefore LoadWithVector, although it doesn't use vector/slot
parameters.

[Jakob Kummerow, 2017-01-10 10:32:18]

Thanks, addressed. Landing.

https://codereview.chromium.org/2623483002/diff/1/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2623483002/diff/1/src/builtins/builtins.h#new...
src/builtins/builtins.h:216: TFS(KeyedLoadIC_Slow, HANDLER, Code::KEYED_LOAD_IC,
Load)                    \
On 2017/01/09 12:05:18, Igor Sheludko wrote:
> It's a handler therefore LoadWithVector, although it doesn't use vector/slot
> parameters.

Done.

[Jakob Kummerow, 2017-01-10 10:32:22]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-01-10 10:32:22]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2623483002/#ps20001
(title: "fix nit")

[commit-bot: I haz the power, 2017-01-10 10:32:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 10:33:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 10:33:43]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/15242)

[Jakob Kummerow, 2017-01-10 10:49:29]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-01-10 10:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2623483002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-01-10 10:49:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 11:40:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484045369480330,
"parent_rev": "32c0dff26322af95eb761764d1c1f60336d4a760", "commit_rev":
"099abc58a16d9d92c4939dddc96ef98a4f60e870"}

[commit-bot: I haz the power, 2017-01-10 11:40:58]

Description was changed from

==========
[cleanup] Port KeyedLoadIC_{Slow,Miss} to TF and drop unused IC handler code

BUG=v8:5269
==========

to

==========
[cleanup] Port KeyedLoadIC_{Slow,Miss} to TF and drop unused IC handler code

BUG=v8:5269

Review-Url: https://codereview.chromium.org/2623483002
Cr-Commit-Position: refs/heads/master@{#42171}
Committed:
https://chromium.googlesource.com/v8/v8/+/099abc58a16d9d92c4939dddc96ef98a4f6...
==========

[commit-bot: I haz the power, 2017-01-10 11:40:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/099abc58a16d9d92c4939dddc96ef98a4f6...