Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2623473002: [turbofan] Remove eager checkpoint. (Closed)

Created:
3 years, 11 months ago by Franzi
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager checkpoint. ToName, ToObject, and ToNumber do not need an eager checkpoint. BUG= Review-Url: https://codereview.chromium.org/2623473002 Cr-Commit-Position: refs/heads/master@{#42136} Committed: https://chromium.googlesource.com/v8/v8/+/7c7e188885bb3a43af0652efb7a93d668778ad70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Franzi
Removed the extra checkpoints. PTAL. Thanks, Franzi
3 years, 11 months ago (2017-01-09 10:52:53 UTC) #4
Benedikt Meurer
Hah! LGTM :-)
3 years, 11 months ago (2017-01-09 10:53:49 UTC) #5
rmcilroy
On 2017/01/09 10:53:49, Benedikt Meurer wrote: > Hah! LGTM :-) Nice! thanks!
3 years, 11 months ago (2017-01-09 10:55:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623473002/1
3 years, 11 months ago (2017-01-09 11:32:56 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 11:35:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7c7e188885bb3a43af0652efb7a93d66877...

Powered by Google App Engine
This is Rietveld 408576698