Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2623423005: [tracing] Avoid flushing system cache when not supported (Closed)

Created:
3 years, 11 months ago by hjd
Modified:
3 years, 11 months ago
Reviewers:
nednguyen, perezju
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : avoid flushing system cache when not supported #

Total comments: 1

Patch Set 3 : add warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M telemetry/telemetry/internal/browser/browser.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
hjd
3 years, 11 months ago (2017-01-13 11:24:28 UTC) #2
hjd
ptal, thanks!
3 years, 11 months ago (2017-01-13 11:34:04 UTC) #3
nednguyen
lgtm Though I am really puzzled by how your last patch got through the CQ
3 years, 11 months ago (2017-01-13 13:25:59 UTC) #4
nednguyen
https://codereview.chromium.org/2623423005/diff/20001/telemetry/telemetry/internal/browser/browser.py File telemetry/telemetry/internal/browser/browser.py (right): https://codereview.chromium.org/2623423005/diff/20001/telemetry/telemetry/internal/browser/browser.py#newcode52 telemetry/telemetry/internal/browser/browser.py:52: self.platform.FlushEntireSystemCache() Add another else & add log.warning: "Flush system ...
3 years, 11 months ago (2017-01-13 13:27:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623423005/40001
3 years, 11 months ago (2017-01-13 15:25:42 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 15:46:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698