Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 2623423004: DevTools: add interventions message source into log entries. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add interventions message source into log entries. Review-Url: https://codereview.chromium.org/2623423004 Cr-Commit-Position: refs/heads/master@{#443505} Committed: https://chromium.googlesource.com/chromium/src/+/d310c8c6b2f814159adfc056a7a0a4d420604670

Patch Set 1 #

Total comments: 1

Patch Set 2 : same w/ frontend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M third_party/WebKit/Source/core/inspector/ConsoleTypes.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
pfeldman
3 years, 11 months ago (2017-01-13 00:58:12 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2623423004/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2623423004/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json#newcode4377 third_party/WebKit/Source/core/inspector/browser_protocol.json:4377: { "name": "source", "type": "string", "enum": ["xml", "javascript", ...
3 years, 11 months ago (2017-01-13 01:55:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623423004/20001
3 years, 11 months ago (2017-01-13 02:03:37 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 06:16:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d310c8c6b2f814159adfc056a7a0...

Powered by Google App Engine
This is Rietveld 408576698