Issue 2623413003: Implement custom status file expectations.

Issue 2623413003: Implement custom status file expectations. (Closed)

Created:
3 years, 11 months ago by ahe

Modified:
3 years, 11 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, Bill Hesse

Target Ref:
refs/heads/fe_integration

Visibility:
Public.

More Reviews

Description

Implement custom status file expectations. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/08bec786902a51817a76632ec8492b306e88dac3

Patch Set 2 : Address review comments. #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -128 lines)			Patch
M	pkg/testing/lib/src/chain.dart	View		8 chunks	+32 lines, -27 lines	0 comments	Download
A	pkg/testing/lib/src/expectation.dart	View	1	1 chunk	+120 lines, -0 lines	0 comments	Download
M	pkg/testing/lib/src/log.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/testing/lib/src/test_dart/status_file_parser.dart	View		6 chunks	+11 lines, -99 lines	0 comments	Download
M	pkg/testing/lib/testing.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2622383003 Patch 20001

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

karlklose

LGTM https://codereview.chromium.org/2623413003/diff/20001/pkg/testing/lib/src/expectation.dart File pkg/testing/lib/src/expectation.dart (right): https://codereview.chromium.org/2623413003/diff/20001/pkg/testing/lib/src/expectation.dart#newcode6 pkg/testing/lib/src/expectation.dart:6: Please add some documentation that explains the difference ...

3 years, 11 months ago (2017-01-16 08:09:20 UTC) #4

ahe

Thank you, Karl! https://codereview.chromium.org/2623413003/diff/20001/pkg/testing/lib/src/expectation.dart File pkg/testing/lib/src/expectation.dart (right): https://codereview.chromium.org/2623413003/diff/20001/pkg/testing/lib/src/expectation.dart#newcode6 pkg/testing/lib/src/expectation.dart:6: On 2017/01/16 08:09:20, karlklose wrote: > ...

3 years, 11 months ago (2017-01-16 08:53:04 UTC) #5

ahe

3 years, 11 months ago (2017-01-16 08:53:18 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:40001) manually as
08bec786902a51817a76632ec8492b306e88dac3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages