Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: pkg/testing/lib/src/log.dart

Issue 2623413003: Implement custom status file expectations. (Closed)
Patch Set: Address review comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/testing/lib/src/expectation.dart ('k') | pkg/testing/lib/src/test_dart/status_file_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/log.dart
diff --git a/pkg/testing/lib/src/log.dart b/pkg/testing/lib/src/log.dart
index b9e645c94b207d09d4559f6e7d91125667b8c774..5ff7cb85dc8dfba6cd23b0dc11459247a507fc10 100644
--- a/pkg/testing/lib/src/log.dart
+++ b/pkg/testing/lib/src/log.dart
@@ -14,7 +14,7 @@ import 'suite.dart' show
import 'test_description.dart' show
TestDescription;
-import 'test_dart/status_file_parser.dart' show
+import 'expectation.dart' show
Expectation;
/// ANSI escape code for moving cursor one line up.
@@ -106,7 +106,7 @@ void logUnexpectedResult(Suite suite, TestDescription description,
Uri statusFile = suite.statusFile;
if (statusFile != null) {
String path = statusFile.toFilePath();
- if (result.outcome == Expectation.PASS) {
+ if (result.outcome == Expectation.Pass) {
print("The test unexpectedly passed, please update $path.");
} else {
print("The test had the outcome ${result.outcome}, but the status file "
« no previous file with comments | « pkg/testing/lib/src/expectation.dart ('k') | pkg/testing/lib/src/test_dart/status_file_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698