Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2623413002: Fix inconsistent keyboard focus style in quick view buttons. (Closed)

Created:
3 years, 11 months ago by oka
Modified:
3 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix inconsistent keyboard focus style in quick view buttons. Updated the open file button's outline to be consistent with the outline of metadata box toggle button. TEST=manually. BUG=663669 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2623413002 Cr-Commit-Position: refs/heads/master@{#443169} Committed: https://chromium.googlesource.com/chromium/src/+/e0959faf15de830455fa90014920adec9c880bc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/foreground/elements/files_quick_view.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
oka
PTAL.
3 years, 11 months ago (2017-01-12 05:24:12 UTC) #4
fukino
lgtm
3 years, 11 months ago (2017-01-12 06:08:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623413002/1
3 years, 11 months ago (2017-01-12 06:20:49 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 06:27:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0959faf15de830455fa90014920...

Powered by Google App Engine
This is Rietveld 408576698