RELAND: MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available

RELAND: MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available


Original CL got reverted due to 2 LayoutTests failing in a single bot:
(Mac Retina bot)
fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html

This bot compiles with no proprietary codecs. H264 was selected
as potentially accelerated by the platform (correct) but H264 was
not enabled in this platform, so we hit a DCHECK().

This CL makes sure that H264 is not considered if
#if BUILDFLAG(RTC_USE_H264
is false.


Original CL description ------------------------------------------------
MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available

This CL adds a static method to VTR to query which
one, if any, is the preferred video codec.

A new singleton Lazy Leaky class CodecEnumerator is
added to encapsulate poking the VEA to see which
codecs are supported, and to further query
a) the preferred codec id
b) if a given codec is supported
and wraps the previous CodecIdToVEAProfile()
functionality.

BUG=679946
Review-Url: https://codereview.chromium.org/2623353004
Cr-Commit-Position: refs/heads/master@{#443400}
Committed: https://chromium.googlesource.com/chromium/src/+/05574f4462f910edf41883479fcffabc21e2198f

[mcasas, 2017-01-12 22:35:30]

Description was changed from

==========
RELAND: MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when
available


Original CL got reverted due to 2 LayoutTests failing in a single bot:
(Mac Retina bot)
fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html


Original CL description ------------------------------------------------
MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available

This CL adds a static method to VTR to query which
one, if any, is the preferred video codec.

A new singleton Lazy Leaky class CodecEnumerator is
added to encapsulate poking the VEA to see which
codecs are supported, and to further query
a) the preferred codec id
b) if a given codec is supported
and wraps the previous CodecIdToVEAProfile()
functionality.

BUG=679946
==========

to

==========
RELAND: MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when
available


Original CL got reverted due to 2 LayoutTests failing in a single bot:
(Mac Retina bot)
fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html

This bot compiles with no proprietary codecs. H264 was selected
as potentially accelerated by the platform (correct) but H264 was
not enabled in this platform, so we hit a DCHECK().

This CL makes sure that H264 is not considered if
#if BUILDFLAG(RTC_USE_H264
is false.


Original CL description ------------------------------------------------
MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available

This CL adds a static method to VTR to query which
one, if any, is the preferred video codec.

A new singleton Lazy Leaky class CodecEnumerator is
added to encapsulate poking the VEA to see which
codecs are supported, and to further query
a) the preferred codec id
b) if a given codec is supported
and wraps the previous CodecIdToVEAProfile()
functionality.

BUG=679946
==========

[mcasas, 2017-01-12 22:36:42]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2017-01-12 22:36:56]

mcasas@chromium.org changed reviewers:
+ emircan@chromium.org

[mcasas, 2017-01-12 22:36:57]

emircan@ PTAL

[commit-bot: I haz the power, 2017-01-12 22:37:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emircan, 2017-01-12 22:39:26]

lgtm

[commit-bot: I haz the power, 2017-01-12 23:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 23:41:31]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-01-12 23:42:07]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-01-12 23:43:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:11:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484264527601170,
"parent_rev": "100c919f8fc51a06aee219a6898424f006cca92a", "commit_rev":
"05574f4462f910edf41883479fcffabc21e2198f"}

[commit-bot: I haz the power, 2017-01-13 00:12:25]

Description was changed from

==========
RELAND: MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when
available


Original CL got reverted due to 2 LayoutTests failing in a single bot:
(Mac Retina bot)
fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html

This bot compiles with no proprietary codecs. H264 was selected
as potentially accelerated by the platform (correct) but H264 was
not enabled in this platform, so we hit a DCHECK().

This CL makes sure that H264 is not considered if
#if BUILDFLAG(RTC_USE_H264
is false.


Original CL description ------------------------------------------------
MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available

This CL adds a static method to VTR to query which
one, if any, is the preferred video codec.

A new singleton Lazy Leaky class CodecEnumerator is
added to encapsulate poking the VEA to see which
codecs are supported, and to further query
a) the preferred codec id
b) if a given codec is supported
and wraps the previous CodecIdToVEAProfile()
functionality.

BUG=679946
==========

to

==========
RELAND: MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when
available


Original CL got reverted due to 2 LayoutTests failing in a single bot:
(Mac Retina bot)
fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html

This bot compiles with no proprietary codecs. H264 was selected
as potentially accelerated by the platform (correct) but H264 was
not enabled in this platform, so we hit a DCHECK().

This CL makes sure that H264 is not considered if
#if BUILDFLAG(RTC_USE_H264
is false.


Original CL description ------------------------------------------------
MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available

This CL adds a static method to VTR to query which
one, if any, is the preferred video codec.

A new singleton Lazy Leaky class CodecEnumerator is
added to encapsulate poking the VEA to see which
codecs are supported, and to further query
a) the preferred codec id
b) if a given codec is supported
and wraps the previous CodecIdToVEAProfile()
functionality.

BUG=679946

Review-Url: https://codereview.chromium.org/2623353004
Cr-Commit-Position: refs/heads/master@{#443400}
Committed:
https://chromium.googlesource.com/chromium/src/+/05574f4462f910edf41883479fcf...
==========

[commit-bot: I haz the power, 2017-01-13 00:12:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/05574f4462f910edf41883479fcf...