Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2623333004: Update EarlGrey bug references for device tests. (Closed)

Created:
3 years, 11 months ago by baxley
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update EarlGrey bug references for device tests. Page state and context menu tests were disabled and have more specific bugs than the TODO contains. BUG=675015, 675399, 675247 Review-Url: https://codereview.chromium.org/2623333004 Cr-Commit-Position: refs/heads/master@{#443562} Committed: https://chromium.googlesource.com/chromium/src/+/b7e5bd98c1437438f89230f581960e27c0e61b66

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert PageState change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/web/shell/test/context_menu_egtest.mm View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
baxley
Updating comments to reflect the more specific bugs.
3 years, 11 months ago (2017-01-12 23:45:09 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2623333004/diff/1/ios/web/shell/test/page_state_egtest.mm File ios/web/shell/test/page_state_egtest.mm (right): https://codereview.chromium.org/2623333004/diff/1/ios/web/shell/test/page_state_egtest.mm#newcode60 ios/web/shell/test/page_state_egtest.mm:60: // TODO(crbug.com/675247): Re-enable this test on device. I've ...
3 years, 11 months ago (2017-01-13 00:01:15 UTC) #3
baxley
https://codereview.chromium.org/2623333004/diff/1/ios/web/shell/test/page_state_egtest.mm File ios/web/shell/test/page_state_egtest.mm (right): https://codereview.chromium.org/2623333004/diff/1/ios/web/shell/test/page_state_egtest.mm#newcode60 ios/web/shell/test/page_state_egtest.mm:60: // TODO(crbug.com/675247): Re-enable this test on device. On 2017/01/13 ...
3 years, 11 months ago (2017-01-13 15:08:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623333004/20001
3 years, 11 months ago (2017-01-13 15:09:26 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 15:30:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b7e5bd98c1437438f89230f58196...

Powered by Google App Engine
This is Rietveld 408576698