Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2623273006: Fix crash in CSS.getLayoutTreeAndStyles (Closed)

Created:
3 years, 11 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
Sami, chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in CSS.getLayoutTreeAndStyles For pages where there was a FrameOwnerElement with a null ContentDocument CSS.getLayoutTreeAndStyles would crash. This patch fixes that. BUG=680497, 546953 Review-Url: https://codereview.chromium.org/2623273006 Cr-Commit-Position: refs/heads/master@{#443513} Committed: https://chromium.googlesource.com/chromium/src/+/cc53e06971c8c55c85642a44fd350ebc092a5e8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
alex clarke (OOO till 29th)
PTAL :)
3 years, 11 months ago (2017-01-12 17:16:44 UTC) #3
dgozman
lgtm
3 years, 11 months ago (2017-01-12 21:31:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623273006/1
3 years, 11 months ago (2017-01-13 07:20:14 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 07:24:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc53e06971c8c55c85642a44fd35...

Powered by Google App Engine
This is Rietveld 408576698