Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2623273004: Revert ExtendableMessageEvent same heap verification. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
haraken, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert ExtendableMessageEvent same heap verification. Revert r440390's debug instrumentation of ExtendableMessageEvent. R= BUG=655926 Review-Url: https://codereview.chromium.org/2623273004 Cr-Commit-Position: refs/heads/master@{#443299} Committed: https://chromium.googlesource.com/chromium/src/+/8f00e720aadeb5fdd7b14d86b1420124fbf92f00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp View 2 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-12 13:39:00 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-12 15:57:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623273004/1
3 years, 11 months ago (2017-01-12 16:23:55 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 18:38:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f00e720aadeb5fdd7b14d86b142...

Powered by Google App Engine
This is Rietveld 408576698