arc: Remove ArcServiceManager::Observer

arc: Remove ArcServiceManager::Observer

The interface is no longer needed since we've added GetService<T>()
to the manager class.

BUG=672840
TEST=try

Review-Url: https://codereview.chromium.org/2623273003
Cr-Commit-Position: refs/heads/master@{#443152}
Committed: https://chromium.googlesource.com/chromium/src/+/aae2a1b19c41c9e56085365a72593a9332098b48

[Yusuke Sato, 2017-01-11 21:51:41]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 21:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-01-11 22:13:18]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 22:14:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-01-11 22:32:10]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 22:33:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-01-11 23:12:37]

yusukes@chromium.org changed reviewers:
+ derat@chromium.org, kinaba@chromium.org, lhchavez@chromium.org

[Yusuke Sato, 2017-01-11 23:12:38]

OWNERs, please take a look.

https://codereview.chromium.org/2623273003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/file_manager/event_router.cc (left):

https://codereview.chromium.org/2623273003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/file_manager/event_router.cc:415: if
(arc::ArcServiceManager::IsInitialized())
kinaba: I've removed IsInitialized() from the manager class and used Get()
instead. Since hidehiko@ recently removed the DCHECK() from the getter, we can
safely call the getter in Shutdown() now.

https://codereview.chromium.org/2623273003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/note_taking_helper.h (right):

https://codereview.chromium.org/2623273003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/note_taking_helper.h:8: #include <memory>
This is for removing an IWYU warning from git-cl lint.

[commit-bot: I haz the power, 2017-01-11 23:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:14:43]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2017-01-11 23:24:33]

lgtm

[Yusuke Sato, 2017-01-12 00:16:14]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 00:17:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-01-12 00:18:01]

Thanks! Luis/kinaba, PTAL.

[Luis Héctor Chávez, 2017-01-12 00:21:13]

thanks, looks much cleaner now :) lgtm

https://codereview.chromium.org/2623273003/diff/40001/components/arc/intent_h...
File components/arc/intent_helper/arc_intent_helper_bridge.h (right):

https://codereview.chromium.org/2623273003/diff/40001/components/arc/intent_h...
components/arc/intent_helper/arc_intent_helper_bridge.h:90: // Gets an
ArcIntentHelperBridge instance in |service_manager|. Returns
nit: Gets the ArcIntentHelperBridge...

[Yusuke Sato, 2017-01-12 00:30:57]

https://codereview.chromium.org/2623273003/diff/40001/components/arc/intent_h...
File components/arc/intent_helper/arc_intent_helper_bridge.h (right):

https://codereview.chromium.org/2623273003/diff/40001/components/arc/intent_h...
components/arc/intent_helper/arc_intent_helper_bridge.h:90: // Gets an
ArcIntentHelperBridge instance in |service_manager|. Returns
On 2017/01/12 00:21:13, Luis Héctor Chávez wrote:
> nit: Gets the ArcIntentHelperBridge...

Done (PS#4 doesn't have the function)

[commit-bot: I haz the power, 2017-01-12 01:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 01:04:33]

Dry run: This issue passed the CQ dry run.

[kinaba, 2017-01-12 04:09:26]

lgtm

[Yusuke Sato, 2017-01-12 04:10:16]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2017-01-12 04:10:16]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2623273003/#ps60001
(title: "Moved Get() to the manager class per (verbal) feedback from Luis")

[commit-bot: I haz the power, 2017-01-12 04:10:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 04:15:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484194216131000,
"parent_rev": "602d5018eae1d34922f1aae754d007acb069f06f", "commit_rev":
"aae2a1b19c41c9e56085365a72593a9332098b48"}

[commit-bot: I haz the power, 2017-01-12 04:16:06]

Description was changed from

==========
arc: Remove ArcServiceManager::Observer

The interface is no longer needed since we've added GetService<T>()
to the manager class.

BUG=672840
TEST=try
==========

to

==========
arc: Remove ArcServiceManager::Observer

The interface is no longer needed since we've added GetService<T>()
to the manager class.

BUG=672840
TEST=try

Review-Url: https://codereview.chromium.org/2623273003
Cr-Commit-Position: refs/heads/master@{#443152}
Committed:
https://chromium.googlesource.com/chromium/src/+/aae2a1b19c41c9e56085365a7259...
==========

[commit-bot: I haz the power, 2017-01-12 04:16:08]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/aae2a1b19c41c9e56085365a7259...