Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2623263006: Add revalidation_only option to precache config. (Closed)

Created:
3 years, 11 months ago by twifkak
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Add revalidation_only option to precache config. When specified, resources are only fetched over the network if they have an existing cache entry with revalidation headers. This serves as a lower-bound approximation of the efficacy of a client-only wifi precache mechanism, as it is limited to URLs that are only on the client AND in the manifests. BUG=679533 Review-Url: https://codereview.chromium.org/2614403003 Cr-Commit-Position: refs/heads/master@{#442999} (cherry picked from commit 8586921e08baafc1209e66223d0642d6246094b9) Review-Url: https://codereview.chromium.org/2623263006 . Cr-Commit-Position: refs/branch-heads/2924@{#748} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/dfc79d6a2692eede9e158d649e42a8e9567b65f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -16 lines) Patch
M components/precache/core/precache_fetcher.h View 2 chunks +16 lines, -3 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 5 chunks +11 lines, -5 lines 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 6 chunks +76 lines, -8 lines 0 comments Download
M components/precache/core/proto/precache.proto View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
twifkak
3 years, 11 months ago (2017-01-12 22:42:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dfc79d6a2692eede9e158d649e42a8e9567b65f0.

Powered by Google App Engine
This is Rietveld 408576698