Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Issue 2623233002: Modifies BlockCleanupTest so that it can be used from ARC code. (Closed)

Created:
3 years, 11 months ago by stkhapugin
Modified:
3 years, 11 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modifies BlockCleanupTest so that it can be used from ARC code. Since ARC code cannot refer to NSAutoreleasePool directly, before this change block_cleanup_test.h cannot be included from ARC-enabled code. With this change, the header lists block_cleanup_pool_ as id, which allows such includes. BUG=None Review-Url: https://codereview.chromium.org/2623233002 Cr-Commit-Position: refs/heads/master@{#442927} Committed: https://chromium.googlesource.com/chromium/src/+/cc331493b0ed0d6bc3cba5499f1f51326199feae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ios/chrome/test/block_cleanup_test.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/block_cleanup_test.mm View 2 chunks +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
stkhapugin
PTAL
3 years, 11 months ago (2017-01-11 16:25:14 UTC) #2
sdefresne
lgtm
3 years, 11 months ago (2017-01-11 16:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623233002/1
3 years, 11 months ago (2017-01-11 16:41:20 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 16:51:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc331493b0ed0d6bc3cba5499f1f...

Powered by Google App Engine
This is Rietveld 408576698