Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/gn/xcode_writer.h

Issue 2623203004: Consolidate Xcode Project Setup (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/xcode_object.cc ('k') | tools/gn/xcode_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xcode_writer.h
diff --git a/tools/gn/xcode_writer.h b/tools/gn/xcode_writer.h
index 37f49d6c0b635d35c27b0c5dea129fefb7768e6f..4973135850886057c88e9acda78902b0161575bc 100644
--- a/tools/gn/xcode_writer.h
+++ b/tools/gn/xcode_writer.h
@@ -16,7 +16,6 @@
class Builder;
class BuildSettings;
class Err;
-class SourceDir;
class Target;
using PBXAttributes = std::map<std::string, std::string>;
@@ -69,6 +68,7 @@ class XcodeWriter {
// (i.e. targets that have a build artefact usable from Xcode, mostly
// application bundles).
void CreateProductsProject(const std::vector<const Target*>& targets,
+ const std::vector<const Target*>& all_targets,
const PBXAttributes& attributes,
const std::string& source_path,
const std::string& config_name,
@@ -77,16 +77,6 @@ class XcodeWriter {
const BuildSettings* build_settings,
TargetOsType target_os);
- // Generates the "sources.xcodeproj" project that reference all source
- // files to allow Xcode to index them.
- void CreateSourcesProject(const std::vector<const Target*>& targets,
- const SourceDir& root_build_dir,
- const PBXAttributes& attributes,
- const std::string& source_path,
- const std::string& absolute_source_path,
- const std::string& config_name,
- TargetOsType target_os);
-
bool WriteFiles(const BuildSettings* build_settings, Err* err);
bool WriteProjectFile(const BuildSettings* build_settings,
PBXProject* project,
« no previous file with comments | « tools/gn/xcode_object.cc ('k') | tools/gn/xcode_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698