Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/gn/xcode_object.cc

Issue 2623203004: Consolidate Xcode Project Setup (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/build/tools/convert_gn_xcodeproj.py ('k') | tools/gn/xcode_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xcode_object.cc
diff --git a/tools/gn/xcode_object.cc b/tools/gn/xcode_object.cc
index 9854095c3cf3e1617ad0d29812458b9257fddb69..9d574a570debfa9dabe79fa00a002f47aacc6c41 100644
--- a/tools/gn/xcode_object.cc
+++ b/tools/gn/xcode_object.cc
@@ -675,16 +675,16 @@ void PBXProject::AddIndexingTarget() {
PBXAttributes attributes;
attributes["EXECUTABLE_PREFIX"] = "";
attributes["HEADER_SEARCH_PATHS"] = sources_->path();
- attributes["PRODUCT_NAME"] = name_;
+ attributes["PRODUCT_NAME"] = "sources";
PBXFileReference* product_reference = static_cast<PBXFileReference*>(
products_->AddChild(base::MakeUnique<PBXFileReference>(
- std::string(), name_, "compiled.mach-o.executable")));
+ std::string(), "sources", "compiled.mach-o.executable")));
const char product_type[] = "com.apple.product-type.tool";
targets_.push_back(base::MakeUnique<PBXNativeTarget>(
- name_, std::string(), config_name_, attributes, product_type, name_,
- product_reference));
+ "sources", std::string(), config_name_, attributes, product_type,
+ "sources", product_reference));
target_for_indexing_ = static_cast<PBXNativeTarget*>(targets_.back().get());
}
« no previous file with comments | « ios/build/tools/convert_gn_xcodeproj.py ('k') | tools/gn/xcode_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698