Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2623163002: Updating href attribute should not blur. (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating href attribute should not blur. In HTMLAnchorElement::attributeChanged, params.name != hrefAttr && isLink() should have been params.name != hrefAttr || isLink() This CL fixes it, and improves code readability. BUG=679669 Review-Url: https://codereview.chromium.org/2623163002 Cr-Commit-Position: refs/heads/master@{#442855} Committed: https://chromium.googlesource.com/chromium/src/+/ef80b9a60d5b8809711ab18632705e09fe64e3c6

Patch Set 1 #

Messages

Total messages: 18 (12 generated)
tkent
kochi@, would you review this please?
3 years, 11 months ago (2017-01-11 06:31:11 UTC) #8
kochi
lgtm
3 years, 11 months ago (2017-01-11 07:11:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623163002/1
3 years, 11 months ago (2017-01-11 07:42:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97886)
3 years, 11 months ago (2017-01-11 08:43:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623163002/1
3 years, 11 months ago (2017-01-11 08:46:25 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:29:08 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef80b9a60d5b8809711ab1863270...

Powered by Google App Engine
This is Rietveld 408576698