Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2623143006: Alias all wtf/Assertions.h macros to their base/ equivalents. (Closed)

Created:
3 years, 11 months ago by Wez
Modified:
3 years, 11 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Alias all wtf/Assertions.h macros to their base/ equivalents. BUG=596760 Review-Url: https://codereview.chromium.org/2623143006 Cr-Commit-Position: refs/heads/master@{#443377} Committed: https://chromium.googlesource.com/chromium/src/+/e4203db424afef97fd382185990f0308383803d6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -35 lines) Patch
M third_party/WebKit/Source/wtf/Assertions.h View 4 chunks +6 lines, -35 lines 2 comments Download

Messages

Total messages: 19 (10 generated)
Wez
PTAL; aliasing the various WTF macros to their base/ equivalents, as discussed.
3 years, 11 months ago (2017-01-12 02:44:31 UTC) #4
Wez
Ping :)
3 years, 11 months ago (2017-01-12 21:06:38 UTC) #7
esprehn
lgtm
3 years, 11 months ago (2017-01-12 21:08:36 UTC) #8
Wez
Thanks. :) /me waits to be paged for chromium.perf regressing badly...
3 years, 11 months ago (2017-01-12 21:51:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623143006/1
3 years, 11 months ago (2017-01-12 21:51:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e4203db424afef97fd382185990f0308383803d6
3 years, 11 months ago (2017-01-12 21:57:11 UTC) #14
tkent
https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/wtf/Assertions.h File third_party/WebKit/Source/wtf/Assertions.h (left): https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/wtf/Assertions.h#oldcode174 third_party/WebKit/Source/wtf/Assertions.h:174: WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, 0); \ We can remove WTFReportAssertionFailure.
3 years, 11 months ago (2017-01-13 00:17:40 UTC) #16
Wez
https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/wtf/Assertions.h File third_party/WebKit/Source/wtf/Assertions.h (left): https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/wtf/Assertions.h#oldcode174 third_party/WebKit/Source/wtf/Assertions.h:174: WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, 0); \ On 2017/01/13 00:17:40, tkent ...
3 years, 11 months ago (2017-01-13 21:18:55 UTC) #17
Wez
3 years, 11 months ago (2017-01-13 21:22:14 UTC) #18
Message was sent while issue was closed.
On 2017/01/13 21:18:55, Wez wrote:
>
https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/w...
> File third_party/WebKit/Source/wtf/Assertions.h (left):
> 
>
https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/w...
> third_party/WebKit/Source/wtf/Assertions.h:174:
> WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, 0); \
> On 2017/01/13 00:17:40, tkent wrote:
> > We can remove WTFReportAssertionFailure.
> 
> Oh, good point! Removed that and WTFReportBacktrace too.

Uploaded https://codereview.chromium.org/2632643004 with the removal.

Powered by Google App Engine
This is Rietveld 408576698