|
|
Chromium Code Reviews
DescriptionAlias all wtf/Assertions.h macros to their base/ equivalents.
BUG=596760
Review-Url: https://codereview.chromium.org/2623143006
Cr-Commit-Position: refs/heads/master@{#443377}
Committed: https://chromium.googlesource.com/chromium/src/+/e4203db424afef97fd382185990f0308383803d6
Patch Set 1 #
Total comments: 2
Messages
Total messages: 19 (10 generated)
The CQ bit was checked by wez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
wez@chromium.org changed reviewers: + esprehn@chromium.org
PTAL; aliasing the various WTF macros to their base/ equivalents, as discussed.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ping :)
lgtm
The CQ bit was checked by wez@chromium.org
Thanks. :) /me waits to be paged for chromium.perf regressing badly...
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484257837385040, "parent_rev":
"48e8d5c92a0aea1db6d3ad5df0d9ad62b9de7b7a", "commit_rev":
"e4203db424afef97fd382185990f0308383803d6"}
Message was sent while issue was closed.
Description was changed from ========== Alias all wtf/Assertions.h macros to their base/ equivalents. BUG=596760 ========== to ========== Alias all wtf/Assertions.h macros to their base/ equivalents. BUG=596760 Review-Url: https://codereview.chromium.org/2623143006 Cr-Commit-Position: refs/heads/master@{#443377} Committed: https://chromium.googlesource.com/chromium/src/+/e4203db424afef97fd382185990f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e4203db424afef97fd382185990f...
Message was sent while issue was closed.
tkent@chromium.org changed reviewers: + tkent@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/wtf/Assertions.h (left): https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/wtf/Assertions.h:174: WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, 0); \ We can remove WTFReportAssertionFailure.
Message was sent while issue was closed.
https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/wtf/Assertions.h (left): https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/wtf/Assertions.h:174: WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, 0); \ On 2017/01/13 00:17:40, tkent wrote: > We can remove WTFReportAssertionFailure. Oh, good point! Removed that and WTFReportBacktrace too.
Message was sent while issue was closed.
On 2017/01/13 21:18:55, Wez wrote: > https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/w... > File third_party/WebKit/Source/wtf/Assertions.h (left): > > https://codereview.chromium.org/2623143006/diff/1/third_party/WebKit/Source/w... > third_party/WebKit/Source/wtf/Assertions.h:174: > WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, 0); \ > On 2017/01/13 00:17:40, tkent wrote: > > We can remove WTFReportAssertionFailure. > > Oh, good point! Removed that and WTFReportBacktrace too. Uploaded https://codereview.chromium.org/2632643004 with the removal.
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
