Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: content/public/app/BUILD.gn

Issue 2623143005: Only depend on child sources from app in both target (Closed)
Patch Set: attempt for non-win Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # App different than the regular content subcomponents (see comments in 5 # App different than the regular content subcomponents (see comments in
6 # //content/BUILD.gn) because it has to support the browser/child process split 6 # //content/BUILD.gn) because it has to support the browser/child process split
7 # (the "both" target include both browser and child process files and is used 7 # (the "both" target include both browser and child process files and is used
8 # for testing). 8 # for testing).
9 # 9 #
10 # In non-component mode, browser, child, and both all follow the same structure: 10 # In non-component mode, browser, child, and both all follow the same structure:
(...skipping 20 matching lines...) Expand all
31 "content_main_delegate.h", 31 "content_main_delegate.h",
32 "content_main_runner.h", 32 "content_main_runner.h",
33 "sandbox_helper_win.h", 33 "sandbox_helper_win.h",
34 ] 34 ]
35 35
36 public_app_shared_deps = [ 36 public_app_shared_deps = [
37 "//base", 37 "//base",
38 "//base:i18n", 38 "//base:i18n",
39 "//content:export", 39 "//content:export",
40 "//content/public/common:common_sources", 40 "//content/public/common:common_sources",
41 "//content/public/gpu:gpu_sources",
42 "//content/public/renderer:renderer_sources",
43 "//content/public/utility:utility_sources",
44 ] 41 ]
45 42
43 if (!is_win || is_component_build) {
44 public_app_shared_deps += [
brettw 2017/01/12 22:51:37 Can you add a comment here about why this is neces
45 "//content/public/gpu:gpu_sources",
46 "//content/public/renderer:renderer_sources",
47 "//content/public/utility:utility_sources",
48 ]
49 }
50
46 if (use_aura) { 51 if (use_aura) {
47 public_app_shared_deps += [ "//ui/aura" ] 52 public_app_shared_deps += [ "//ui/aura" ]
48 } 53 }
49 54
50 if (is_component_build) { 55 if (is_component_build) {
51 source_set("both_sources") { 56 source_set("both_sources") {
52 # Only the main content shared library can pull this in. 57 # Only the main content shared library can pull this in.
53 visibility = [ "//content:content" ] 58 visibility = [ "//content:content" ]
54 59
55 sources = public_app_shared_sources 60 sources = public_app_shared_sources
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 203
199 service_manifest("renderer_manifest") { 204 service_manifest("renderer_manifest") {
200 name = "content_renderer" 205 name = "content_renderer"
201 source = "mojo/content_renderer_manifest.json" 206 source = "mojo/content_renderer_manifest.json"
202 } 207 }
203 208
204 service_manifest("utility_manifest") { 209 service_manifest("utility_manifest") {
205 name = "content_utility" 210 name = "content_utility"
206 source = "mojo/content_utility_manifest.json" 211 source = "mojo/content_utility_manifest.json"
207 } 212 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698