Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2329)

Unified Diff: content/public/app/BUILD.gn

Issue 2623143005: Only depend on child sources from app in both target (Closed)
Patch Set: attempt for non-win Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/app/BUILD.gn
diff --git a/content/public/app/BUILD.gn b/content/public/app/BUILD.gn
index d09712d3138203415395d8d547072548ed798b47..28ba8ed112bc8b830656b722f37f62bf4e46f9d1 100644
--- a/content/public/app/BUILD.gn
+++ b/content/public/app/BUILD.gn
@@ -38,11 +38,16 @@ public_app_shared_deps = [
"//base:i18n",
"//content:export",
"//content/public/common:common_sources",
- "//content/public/gpu:gpu_sources",
- "//content/public/renderer:renderer_sources",
- "//content/public/utility:utility_sources",
]
+if (!is_win || is_component_build) {
+ public_app_shared_deps += [
brettw 2017/01/12 22:51:37 Can you add a comment here about why this is neces
+ "//content/public/gpu:gpu_sources",
+ "//content/public/renderer:renderer_sources",
+ "//content/public/utility:utility_sources",
+ ]
+}
+
if (use_aura) {
public_app_shared_deps += [ "//ui/aura" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698