third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js - Issue 2623143002: DevTools: insert console message decorations in order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

Issue 2623143002: DevTools: insert console message decorations in order

Patch Set: address design comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

index 6fe0efe49445a809b28625091d7c82630726dd80..05319edee8c87fcd7768a81fec226279bc3d81ce 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

@@ -606,7 +606,7 @@ SDK.ServiceWorkerContextNamer = class {

var parsedUrl = context.origin.asParsedURL();

var label = parsedUrl ? parsedUrl.lastPathComponentWithFragment() : context.name;

if (version)

- context.setLabel(label + ' #' + version.id + ' (' + version.status + ')');

+ context.setLabel(label, version.id, version.status);

else

context.setLabel(label);

}