third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js - Issue 2623143002: DevTools: insert console message decorations in order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

Issue 2623143002: DevTools: insert console message decorations in order

Patch Set: address design comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

index 8247d9e5001c12e635ddfe55cc8c67d7cac758e9..0f7ac280be884dd1d48c050f3f2e9722e6e9aa31 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

@@ -192,7 +192,8 @@ Sources.ThreadsSidebarPane = class extends UI.VBox {

if (!target)

return pendingTarget.name();

var executionContext = target.runtimeModel.defaultExecutionContext();

- return executionContext && executionContext.label() ? executionContext.label() : target.name();

+ var label = executionContext ? executionContext.label(true /* showStatus */) : null;

+ return label || target.name();

}

/**

@@ -213,8 +214,8 @@ Sources.ThreadsSidebarPane = class extends UI.VBox {

return;

var pendingTarget = this._targetToPending.get(executionContext.target());

var listItem = this._pendingToListItem.get(pendingTarget);

- if (listItem && executionContext.label())

- listItem.setTitle(executionContext.label());

+ if (listItem && executionContext.label(true /* showStatus */))

+ listItem.setTitle(executionContext.label(true /* showStatus */));

}

/**