Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2623133002: X87: [wasm] Prerequisites for WebAssembly Table.Grow. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
gdeepti, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Prerequisites for WebAssembly Table.Grow. port 0c4b8ff44ce4ef0cae06c964679c98c32f8bd40f (r42192) original commit message: - Refactor Dispatch tables to have separate function, signature tables - New Relocation type for WasmFunctionTableReference, assembler, compiler support. - RelocInfo helper functions for Wasm references BUG= Review-Url: https://codereview.chromium.org/2623133002 Cr-Commit-Position: refs/heads/master@{#42208} Committed: https://chromium.googlesource.com/v8/v8/+/f5631ead779e49028c4b42ea8e2ae755e14bcffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-11 02:58:19 UTC) #2
chunyang.dai
On 2017/01/11 02:58:19, zhengxing.li wrote: > PTAL, thanks! LGTM. thanks
3 years, 11 months ago (2017-01-11 03:01:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623133002/1
3 years, 11 months ago (2017-01-11 03:02:05 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 03:27:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f5631ead779e49028c4b42ea8e2ae755e14...

Powered by Google App Engine
This is Rietveld 408576698