Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2623113003: [Benchmark] Add memory tests for Ignition+TurboFan (Closed)

Created:
3 years, 11 months ago by Michael Hablich
Modified:
3 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Benchmark] Add memory tests for Ignition+TurboFan Added benchmarks: v8.todomvc-turbo, v8.infinite_scroll-turbo_tbmv2, v8.browsing_mobile_turbo, v8.browsing_desktop_turbo R=mvstanton@chromium.org,hpayer@chromium.org BUG=v8:5827 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2623113003 Cr-Commit-Position: refs/heads/master@{#443229} Committed: https://chromium.googlesource.com/chromium/src/+/efd3d8ba87ec8266ab1b5c34cfee31c1121f45ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M tools/perf/benchmarks/v8.py View 2 chunks +28 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/v8_browsing.py View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Michael Hablich
On 2017/01/11 15:46:36, Michael Hablich wrote: > mailto:hablich@chromium.org changed reviewers: > + mailto:nednguyen@google.com PTAL as ...
3 years, 11 months ago (2017-01-11 15:47:08 UTC) #4
mvstanton
Fantastic, thanks Michael. LGTM.
3 years, 11 months ago (2017-01-11 15:58:37 UTC) #7
rmcilroy
LGTM, thanks Michael!
3 years, 11 months ago (2017-01-11 17:17:43 UTC) #8
nednguyen
On 2017/01/11 17:17:43, rmcilroy wrote: > LGTM, thanks Michael! Can you add the name of ...
3 years, 11 months ago (2017-01-11 17:28:09 UTC) #9
Michael Hablich
On 2017/01/11 17:28:09, nednguyen wrote: > On 2017/01/11 17:17:43, rmcilroy wrote: > > LGTM, thanks ...
3 years, 11 months ago (2017-01-11 18:10:48 UTC) #13
nednguyen
lgtm
3 years, 11 months ago (2017-01-11 19:06:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623113003/1
3 years, 11 months ago (2017-01-12 14:46:46 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 14:51:22 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/efd3d8ba87ec8266ab1b5c34cfee...

Powered by Google App Engine
This is Rietveld 408576698