Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2623103002: [layoutng] Fix extra margin space computation (Closed)

Created:
3 years, 11 months ago by atotic
Modified:
3 years, 11 months ago
Reviewers:
cbiesinger
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Fix extra margin space computation The Optional<> rewrite reversed the sign on extra margin space. Also updated test expectations. Down to 165 failed from 207 BUG=635619 Review-Url: https://codereview.chromium.org/2623103002 Cr-Commit-Position: refs/heads/master@{#443419} Committed: https://chromium.googlesource.com/chromium/src/+/8b7f961697115ebfa0dc4eb98a98ff0ab3d1c4a8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -52 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 6 chunks +2 lines, -44 lines 1 comment Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
atotic
3 years, 11 months ago (2017-01-11 01:44:53 UTC) #3
atotic
ptal
3 years, 11 months ago (2017-01-11 17:59:07 UTC) #4
cbiesinger
lgtm https://codereview.chromium.org/2623103002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2623103002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode158 third_party/WebKit/LayoutTests/TestExpectations:158: #### Skipped: 165 \o/
3 years, 11 months ago (2017-01-11 18:26:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623103002/1
3 years, 11 months ago (2017-01-11 18:26:41 UTC) #7
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-11 22:38:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623103002/1
3 years, 11 months ago (2017-01-12 21:22:06 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 00:48:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8b7f961697115ebfa0dc4eb98a98...

Powered by Google App Engine
This is Rietveld 408576698