content/browser/devtools/protocol/network_handler.h - Issue 2623063003: DevTools: Fix getCookies to report for all resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/network_handler.h

Issue 2623063003: DevTools: Fix getCookies to report for all resources (Closed)

Patch Set: audit and line length fixes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/network_handler.h

diff --git a/content/browser/devtools/protocol/network_handler.h b/content/browser/devtools/protocol/network_handler.h

index ba3c5365db9b8804036fa0ea0b1f9db89c9f1500..3ddf6b6d4c3917aa25bebb53e1c39feef87ab84b 100644

--- a/content/browser/devtools/protocol/network_handler.h

+++ b/content/browser/devtools/protocol/network_handler.h

@@ -35,7 +35,8 @@ class NetworkHandler : public DevToolsDomainHandler,

Response ClearBrowserCache() override;

Response ClearBrowserCookies() override;

- void GetCookies(std::unique_ptr<GetCookiesCallback> callback) override;

+ void GetCookies(std::unique_ptr<protocol::Array<std::string>> urls,

+ std::unique_ptr<GetCookiesCallback> callback) override;

void GetAllCookies(std::unique_ptr<GetAllCookiesCallback> callback) override;

void DeleteCookie(const std::string& cookie_name,

const std::string& url,