DevTools: Fix getCookies to report for all resources

content/browser/devtools/protocol/network_handler.cc

Index: content/browser/devtools/protocol/network_handler.cc
diff --git a/content/browser/devtools/protocol/network_handler.cc b/content/browser/devtools/protocol/network_handler.cc
index 60f76e22fe0c94fb9ed50cba64e1b9c8ff5fdeae..b6c62fd5db0a0c334a9b02c2f2cbadb56b0e581d 100644
--- a/content/browser/devtools/protocol/network_handler.cc
+++ b/content/browser/devtools/protocol/network_handler.cc
@@ -210,20 +210,13 @@ class GetCookiesCommandBase {
 class GetCookiesCommand : public GetCookiesCommandBase<GetCookiesCallback> {
  public:
   GetCookiesCommand(RenderFrameHostImpl* frame_host,
+                    std::unique_ptr<protocol::Array<std::string>> urls,
                     std::unique_ptr<GetCookiesCallback> callback)
       : GetCookiesCommandBase(std::move(callback)) {
     net::CookieStore::GetCookieListCallback got_cookies_callback = base::Bind(
         &GetCookiesCommand::GotCookiesForURL, base::Unretained(this));
 
-    std::queue<FrameTreeNode*> queue;
-    queue.push(frame_host->frame_tree_node());
-    while (!queue.empty()) {
-      FrameTreeNode* node = queue.front();
-      queue.pop();
-
-      // Only traverse nodes with the same local root.
-      if (node->current_frame_host()->IsCrossProcessSubframe())
-        continue;
+    for (size_t i = 0; i < urls->length(); i++) {
       ++request_count_;
       BrowserThread::PostTask(

[pfeldman, 2017/01/13 02:17:34]

You should not post as many tasks as there are urls, pass array into a single
task instead.

Also, you might need to maintain existing behavior of url gathering in case no
urls are given in the protocol command. So you can gather first and post the
task after.

[phulce, 2017/01/18 00:52:34]

Done.

           BrowserThread::IO, FROM_HERE,
@@ -234,10 +227,7 @@ class GetCookiesCommand : public GetCookiesCommandBase<GetCookiesCallback> {
                      base::Unretained(frame_host->GetProcess()
                                           ->GetStoragePartition()
                                           ->GetURLRequestContext()),
-                     node->current_url(), got_cookies_callback));
-
-      for (size_t i = 0; i < node->child_count(); ++i)
-        queue.push(node->child_at(i));
+                     GURL(urls->get(i)), got_cookies_callback));
     }
   }
 };
@@ -315,11 +305,12 @@ Response NetworkHandler::ClearBrowserCookies() {
 }
 
 void NetworkHandler::GetCookies(
+    std::unique_ptr<protocol::Array<std::string>> urls,
     std::unique_ptr<GetCookiesCallback> callback) {
   if (!host_)
     callback->sendFailure(Response::InternalError());
   else
-    new GetCookiesCommand(host_, std::move(callback));
+    new GetCookiesCommand(host_, std::move(urls), std::move(callback));
 }
 
 void NetworkHandler::GetAllCookies(