Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2623023002: Remove //chrome as an embedder of blimp. (Closed)

Created:
3 years, 11 months ago by nyquist
Modified:
3 years, 11 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove //chrome as an embedder of blimp. Removes all the Android-code related to blimp from //chrome, and removes all the dependencies of the //blimp directory. This includes all hooks for the UI code, command line flags, resources, and the BrowserContextKeyedService. BUG=677556 Review-Url: https://codereview.chromium.org/2623023002 Cr-Commit-Position: refs/heads/master@{#443007} Committed: https://chromium.googlesource.com/chromium/src/+/63abca50dd2574d883bc241bdb3cb6e46fb8afa5

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebase again #

Patch Set 4 : One more rebase for good measure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1330 lines) Patch
M chrome/android/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 5 chunks +0 lines, -13 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/blimp/BlimpClientContextFactory.java View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/blimp/ui/BlimpMessageBuilder.java View 1 chunk +0 lines, -90 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 2 3 19 chunks +8 lines, -114 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/tab/TabBlimpContentsObserver.java View 1 chunk +0 lines, -80 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/blimp/BlimpMessageBuilderTest.java View 1 chunk +0 lines, -71 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/android/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/android/blimp/blimp_client_context_factory.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/android/blimp/blimp_client_context_factory.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/android/blimp/blimp_client_context_factory_android.h View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/android/blimp/blimp_client_context_factory_android.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/android/blimp/blimp_contents_profile_attachment.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/android/blimp/blimp_contents_profile_attachment.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/android/blimp/chrome_blimp_client_context_delegate.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/android/blimp/chrome_blimp_client_context_delegate_android.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/android/blimp/chrome_blimp_client_context_delegate_android.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/android/blimp/chrome_compositor_dependencies.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/android/blimp/chrome_compositor_dependencies.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/android/preferences/browser_prefs_android.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/android/preferences/command_line_pref_store_android.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/android/preferences/command_line_pref_store_android.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/android/tab_android.h View 4 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 3 chunks +1 line, -45 lines 0 comments Download
M chrome/browser/prefs/chrome_command_line_pref_store.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 27 (21 generated)
nyquist
dtrainor: PTAL
3 years, 11 months ago (2017-01-11 00:32:15 UTC) #11
David Trainor- moved to gerrit
lgtm
3 years, 11 months ago (2017-01-11 17:55:39 UTC) #15
nyquist
sky: PTAL //chrome/browser/prefs/chrome_command_line_pref_store.cc. It no longer refers to the files deleted in this CL from ...
3 years, 11 months ago (2017-01-11 18:18:53 UTC) #18
sky
LGTM
3 years, 11 months ago (2017-01-11 19:03:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623023002/60001
3 years, 11 months ago (2017-01-11 19:10:50 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:14:22 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/63abca50dd2574d883bc241bdb3c...

Powered by Google App Engine
This is Rietveld 408576698