Issue 2623013002: [Merge to M56] Verify precision length before converting to string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2623013002: [Merge to M56] Verify precision length before converting to string. (Closed)

Created:
3 years, 11 months ago by dsinclair

Modified:
3 years, 11 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/chromium/2924

Project:
pdfium

Visibility:
Public.

[Merge to M56] Verify precision length before converting to string. This CL updates the CalculateString method to make sure the number of digits of precision is valid before doing the stringstream conversion. BUG=chromium:673336 TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2572543004 (cherry picked from commit 992ecf7c189e5cabf43e5ad862511cf63d030966) Committed: https://pdfium.googlesource.com/pdfium/+/ca6af90493d76b417824b0322be68e71d00cad41

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	fpdfsdk/javascript/PublicMethods.cpp	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

dsinclair

3 years, 11 months ago (2017-01-10 21:24:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ca6af90493d76b417824b0322be68e71d00cad41 (presubmit successful).