Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2572543004: Verify precision length before converting to string. (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Verify precision length before converting to string. This CL updates the CalculateString method to make sure the number of digits of precision is valid before doing the stringstream conversion. BUG=chromium:673336 Review-Url: https://codereview.chromium.org/2572543004 Committed: https://pdfium.googlesource.com/pdfium/+/992ecf7c189e5cabf43e5ad862511cf63d030966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M fpdfsdk/javascript/PublicMethods.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
dsinclair
PTAL.
4 years ago (2016-12-13 21:28:29 UTC) #4
Tom Sepez
lgtm
4 years ago (2016-12-13 21:30:17 UTC) #5
Tom Sepez
On 2016/12/13 21:30:17, Tom Sepez wrote: > lgtm I think there's also a bug upstream ...
4 years ago (2016-12-13 21:31:01 UTC) #6
dsinclair
On 2016/12/13 21:31:01, Tom Sepez wrote: > On 2016/12/13 21:30:17, Tom Sepez wrote: > > ...
4 years ago (2016-12-14 13:45:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572543004/1
4 years ago (2016-12-14 13:45:42 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-14 13:46:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/992ecf7c189e5cabf43e5ad862511cf63d03...

Powered by Google App Engine
This is Rietveld 408576698