Issue 2622993003: Compare relative url if absolute urls are empty for CSSImageValue

Issue 2622993003: Compare relative url if absolute urls are empty for CSSImageValue (Closed)

Created:
3 years, 11 months ago by Sunghoon Kim

Modified:
3 years, 11 months ago

Reviewers:
Timothy Loh, rune

CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Compare relative url if absolute urls are empty for CSSImageValue Change to compare relative url if absolute urls are all empty while css set property. BUG=660663 Review-Url: https://codereview.chromium.org/2622993003 Cr-Commit-Position: refs/heads/master@{#443864} Committed: https://chromium.googlesource.com/chromium/src/+/67f8202c63cc39ca0a4c3bd444158a7587b9bb4d

Patch Set 2 : add a test case #

Total comments: 2

Patch Set 3 : modified tc #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
M	AUTHORS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/css/background-image-url-setproperty.html	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/CSSImageValue.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 14 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rune

On 2017/01/11 01:46:23, rune wrote: > Please add a test-case. I've also commented in the ...

3 years, 11 months ago (2017-01-11 01:54:12 UTC) #4

Sunghoon Kim

I added a test case using the script in issue description. And how to get ...

3 years, 11 months ago (2017-01-11 03:52:37 UTC) #5

rune

On 2017/01/11 03:52:37, shoon.kim wrote: > I added a test case using the script in ...

3 years, 11 months ago (2017-01-11 14:13:04 UTC) #6

rune

https://codereview.chromium.org/2622993003/diff/20001/third_party/WebKit/LayoutTests/fast/css/background-image-url-setproperty.html File third_party/WebKit/LayoutTests/fast/css/background-image-url-setproperty.html (right): https://codereview.chromium.org/2622993003/diff/20001/third_party/WebKit/LayoutTests/fast/css/background-image-url-setproperty.html#newcode1 third_party/WebKit/LayoutTests/fast/css/background-image-url-setproperty.html:1: <p id="result"> Test should be strict unless specifically testing ...

3 years, 11 months ago (2017-01-11 14:13:14 UTC) #7

Sunghoon Kim

Thanks for your great and kind review. I uploaded with modified test case. It's rebased ...

3 years, 11 months ago (2017-01-16 03:38:08 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622993003/40001

3 years, 11 months ago (2017-01-16 08:24:55 UTC) #11

commit-bot: I haz the power

3 years, 11 months ago (2017-01-16 09:58:54 UTC) #14

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/67f8202c63cc39ca0a4c3bd44415...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages